fix: infinite approval doesn't persist after transfer #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW any reason we can't just inherit OpenZeppelin's ERC20? Personally, I would feel more comfortable. |
I think it’s because we just renamed LUSD from v1 (and I don’t remember why we did that way then). But I agree, I would just import OpenZeppelin ECR20. |
bingen
approved these changes
Jun 19, 2024
I'll give it a go, but if it takes more than 20 minutes, I'll just merge this one and leave OZ for another time. |
Perfect!! Thanks! |
|
It turned out to be really easy. |
|
Hey, I'm taking some time off and have limited access to my emails until
July 8.
My colleague Bianka ***@***.***) is monitoring my inbox.
Stay curious, Cédric
…On Fri, 21 Jun 2024 04:36:50 +0200, Daniel Simon ***@***.***) wrote:
Merged #217 <#217> into main.
—
Reply to this email directly, view it on GitHub
<#217 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADBDRTC3M767FCZ7K2CC2DZIOGUFAVCNFSM6AAAAABJPVSEUCVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTGIZTMNJRGYZDSNA>.
You are receiving this because you are subscribed to this thread.[image:
]Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a know quirk of LUSD/BOLD, wherein an infinite approval is "only" practically infinite, but actually decreases upon each transfer. This made it trickier to detect infinite approvals in the v1 frontend (in the case of ChickenBonds).
This change makes it so infinite approvals stay infinite even after a transfer, which is also what OpenZeppelin does since some time ago:
OpenZeppelin/openzeppelin-contracts#3085